[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master bc8e2d9 13/15: Remove a defunct defect marker
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master bc8e2d9 13/15: Remove a defunct defect marker [307] |
Date: |
Sun, 14 Feb 2021 18:24:54 -0500 (EST) |
branch: master
commit bc8e2d93246da9af4dff4c39b023a62fd929da87
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Remove a defunct defect marker [307]
All the former defects noted have been resolved:
- DB_MgmtFeeFundCharge no longer exists.
- LedgerInvariant::TotalIMF is set equal to this IMF vector.
- Formerly, DynamicMlySepAcctRate() modified it, which was ugly; but
that no longer happens.
- BasicValues::InvestmentManagementFee() returns a scalar today, but
someday IMF very well might vary by duration.
---
interest_rates.cpp | 6 ------
1 file changed, 6 deletions(-)
diff --git a/interest_rates.cpp b/interest_rates.cpp
index dff3d93..c3b4046 100644
--- a/interest_rates.cpp
+++ b/interest_rates.cpp
@@ -364,12 +364,6 @@ void InterestRates::Initialize(BasicValues const& v)
v.database().query_into(DB_LoadAmortFundCharge, AmortLoad_);
}
- // TODO ?? This was once initialized with 'DB_MgmtFeeFundCharge',
- // which has been deprecated and is ignored. Is it still useful?
- // useful? Here, this vector is simply initialized with a scalar,
- // but later it adds rates passed to DynamicMlySepAcctRate(), which
- // seems ugly. Is it ever accessed externally? Does it really need
- // to be a vector?
InvestmentManagementFee_.assign(Length_, v.InvestmentManagementFee());
// Retrieve loan data from class BasicValues.
- [lmi-commits] [lmi] master updated (50d271d -> 3143a30), Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 4405433 01/15: Expunge disused stable-value calculations [320], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master dd991f3 05/15: Resolve a marked defect [315], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master f74f14c 06/15: Avoid non-const reference arguments, Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 48caef4 07/15: Resolve a marked defect [313], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 9b46a92 08/15: Assume genacct and loan rates are always needed [312], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master a7bf1d0 04/15: Remove a duplicative defect marker [316], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master d58eb9b 12/15: Remove assertions that provably cannot fire, Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master bc8e2d9 13/15: Remove a defunct defect marker [307],
Greg Chicares <=
- [lmi-commits] [lmi] master dbac503 14/15: Demote a marked defect [306], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 791ccce 02/15: Expunge disused stable-value fund charge from database, Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 9f4e2a2 09/15: Expunge an unused member function [311], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 387eeaa 10/15: Prepare to resolve some marked defects, Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master cb5e424 11/15: Resolve several marked defects [308], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 4912e96 03/15: Simplify [317], Greg Chicares, 2021/02/14
- [lmi-commits] [lmi] master 3143a30 15/15: Simplify using expression templates [305], Greg Chicares, 2021/02/14