lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master bc8e2d9 13/15: Remove a defunct defect marker


From: Greg Chicares
Subject: [lmi-commits] [lmi] master bc8e2d9 13/15: Remove a defunct defect marker [307]
Date: Sun, 14 Feb 2021 18:24:54 -0500 (EST)

branch: master
commit bc8e2d93246da9af4dff4c39b023a62fd929da87
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Remove a defunct defect marker [307]
    
    All the former defects noted have been resolved:
     - DB_MgmtFeeFundCharge no longer exists.
     - LedgerInvariant::TotalIMF is set equal to this IMF vector.
     - Formerly, DynamicMlySepAcctRate() modified it, which was ugly; but
       that no longer happens.
     - BasicValues::InvestmentManagementFee() returns a scalar today, but
       someday IMF very well might vary by duration.
---
 interest_rates.cpp | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/interest_rates.cpp b/interest_rates.cpp
index dff3d93..c3b4046 100644
--- a/interest_rates.cpp
+++ b/interest_rates.cpp
@@ -364,12 +364,6 @@ void InterestRates::Initialize(BasicValues const& v)
         v.database().query_into(DB_LoadAmortFundCharge, AmortLoad_);
         }
 
-    // TODO ?? This was once initialized with 'DB_MgmtFeeFundCharge',
-    // which has been deprecated and is ignored. Is it still useful?
-    // useful? Here, this vector is simply initialized with a scalar,
-    // but later it adds rates passed to DynamicMlySepAcctRate(), which
-    // seems ugly. Is it ever accessed externally? Does it really need
-    // to be a vector?
     InvestmentManagementFee_.assign(Length_, v.InvestmentManagementFee());
 
     // Retrieve loan data from class BasicValues.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]