Re: [lmi] Build warnings for pre-wx-2.9.5

[Greg Chicares]

On 2013-07-14 18:04Z, Greg Chicares wrote:
> On 2013-07-12 14:13Z, Vadim Zeitlin wrote:
>> On Fri, 12 Jul 2013 13:05:34 +0000 Greg Chicares <address@hidden> wrote:
>> 
>> GC> Building 'wxWidgets-2013-07-11.tar.gz' with gcc-3.4.5, I get about
>> GC> three hundred lines of warnings, almost all of which occur in
>> GC> '../src/stc/'; here's a representative sample:
>> GC> 
>> GC> ../src/stc/scintilla/src/CallTip.cxx:114: warning: converting to `int' 
>> from `XYPOSITION'
> [...]
>>  The trouble with those is that they are in third party code and it would
>> be nice to find some way to avoid them without changing it... And there
>> seem to be a lot of implicit float (XYPOSITION) to int conversions in the
>> Scintilla code. I just hope there are no real bugs there and they can be
>> safely ignored but to be honest I'm far from being sure about it.
>> 
>>  For LMI needs you could just avoid building "stc" library entirely as it's
>> not used by your code. I.e. you could just add "--disable-stc" to configure
>> command line.
> 
> Okay, I've added "--disable-stc". Thanks.
> 
>> 
>> GC> Here are all the warnings that occur outside '../src/stc/',
>> 
>>  Thanks, I've fixed all of them (there were several commits with the last
>> one being r74495) except this one:
>> 
>> GC> ../src/common/docview.cpp: In member function `virtual wxDocument* 
>> wxDocManager::CreateDocument(const wxString&, long int)':
>> GC> ../src/common/docview.cpp:1504: warning: 'docNew' might be used 
>> uninitialized in this function
> 
> Yes, I remember that one.
> 
> Here are the diagnostics I see with new 'wxWidgets-2013-07-14.tar.gz':
> 
> ../src/msw/uiaction.cpp: In member function `bool 
> wxUIActionSimulator::MouseMove(long int, long int)':
> ../src/msw/uiaction.cpp:68: warning: converting to `int' from `double'
> ../src/msw/uiaction.cpp:69: warning: converting to `int' from `double'
> ../src/msw/listctrl.cpp: In member function `wxSize 
> wxListCtrl::MSWGetBestViewRect(int, int) const':
> ../src/msw/listctrl.cpp:1342: warning: passing negative value `-0x000000001' 
> for converting 3 of `LRESULT SendMessageW(HWND__*, UINT, WPARAM, LPARAM)'
> ../src/msw/spinctrl.cpp: In member function `virtual wxSize 
> wxSpinCtrl::DoGetSizeFromTextSize(int, int) const':
> ../src/msw/spinctrl.cpp:735: warning: passing `double' for converting 1 of 
> `wxSize::wxSize(int, int)'
> ../src/common/docview.cpp: In member function `virtual wxDocument* 
> wxDocManager::CreateDocument(const wxString&, long int)':
> ../src/common/docview.cpp:1504: warning: 'docNew' might be used uninitialized 
> in this function
> ../src/generic/spinctlg.cpp: In member function `virtual wxSize 
> wxSpinCtrlGenericBase::DoGetSizeFromTextSize(int, int) const':
> ../src/generic/spinctlg.cpp:287: warning: passing `double' for converting 1 
> of `void wxSize::IncBy(int, int)'
> ../src/generic/richtooltipg.cpp:352: warning: unused parameter 'tipKind'
> In file included from ../src/msw/webview_ie.cpp:17:
> ../include/wx/msw/webview_ie.h:213: warning: `class VirtualProtocol' has 
> virtual functions but non-virtual destructor
> ../include/wx/msw/webview_ie.h:256: warning: `class ClassFactory' has virtual 
> functions but non-virtual destructor
> ../include/wx/msw/webview_ie.h:286: warning: `class DocHostUIHandler' has 
> virtual functions but non-virtual destructor
> In file included from ../src/common/webview.cpp:26:
> ../include/wx/msw/webview_ie.h:213: warning: `class VirtualProtocol' has 
> virtual functions but non-virtual destructor
> ../include/wx/msw/webview_ie.h:256: warning: `class ClassFactory' has virtual 
> functions but non-virtual destructor
> ../include/wx/msw/webview_ie.h:286: warning: `class DocHostUIHandler' has 
> virtual functions but non-virtual destructor
> ../src/msw/webview_ie.cpp: In member function `virtual long int 
> wxWebViewIE::Find(const wxString&, int)':
> ../src/msw/webview_ie.cpp:675: warning: converting of negative value 
> `-0x000000001' to `unsigned int'

Same warnings with 'wxWidgets-2013-07-15.tar.gz' snapshot.