lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Group quotes, part deux


From: Greg Chicares
Subject: Re: [lmi] Group quotes, part deux
Date: Fri, 20 May 2016 11:41:07 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0

On 2016-05-20 01:34, Greg Chicares wrote:
[...]
> Here's something that works well enough to share for discussion
> (but I won't rush to commit it). In a comment, I pose a question
> addressed to you:
> 
> Index: group_quote_pdf_gen_wx.cpp
> ===================================================================
> --- group_quote_pdf_gen_wx.cpp(revision 6609)
> +++ group_quote_pdf_gen_wx.cpp(working copy)
> @@ -1347,18 +1347,41 @@
>          // Only premium columns have averages, but we must output something 
> for
>          // all cells to ensure that we use homogeneous background.
[...]
> +        // Vadim--Suppose (0.0 != divisor). Then average_text is an
> +        // empty string. Does that satisfy "we must output something"
> +        // above?

I'm eager to know the answer, as I am about to make a change here.
I'm assuming that an empty string is "something", because that's
what was already being used for "face amount" columns anyway.

The patch I posted for discussion isn't right, but it had the
benefit of prompting a discussion from which we concluded that
no "average" should be defined for "additional premium". I'll
make that change and declare a new release candidate soon.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]