Re: [lmi] Group quotes, part deux

[Vadim Zeitlin]

On Fri, 20 May 2016 12:58:53 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2016-05-20 11:41, Greg Chicares wrote:
GC> > On 2016-05-20 01:34, Greg Chicares wrote:
GC> > [...]
GC> >> Here's something that works well enough to share for discussion
GC> >> (but I won't rush to commit it). In a comment, I pose a question
GC> >> addressed to you:
GC> >> 
GC> >> Index: group_quote_pdf_gen_wx.cpp
GC> >> ===================================================================
GC> >> --- group_quote_pdf_gen_wx.cpp(revision 6609)
GC> >> +++ group_quote_pdf_gen_wx.cpp(working copy)
GC> >> @@ -1347,18 +1347,41 @@
GC> >>          // Only premium columns have averages, but we must output 
something for
GC> >>          // all cells to ensure that we use homogeneous background.
GC> > [...]
GC> >> +        // Vadim--Suppose (0.0 != divisor). Then average_text is an
GC> >> +        // empty string. Does that satisfy "we must output something"
GC> >> +        // above?
GC> > 
GC> > I'm eager to know the answer, as I am about to make a change here.
GC> > I'm assuming that an empty string is "something", because that's
GC> > what was already being used for "face amount" columns anyway.
GC> 
GC> Using that assumption, which must be right...

 Yes, exactly for the reason mentioned above.

GC> > The patch I posted for discussion isn't right, but it had the
GC> > benefit of prompting a discussion from which we concluded that
GC> > no "average" should be defined for "additional premium". I'll
GC> > make that change
GC> 
GC> Committed 20160520T1247Z, revision 6610.

 Thanks!
VZ