Re: [lmi] PCH

[Greg Chicares]

On 2016-06-05 22:23, Vadim Zeitlin wrote:
> On Sun, 5 Jun 2016 22:04:32 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> (1) #include LMI_PCH_HEADER
> GC> 
> GC> What macro definition makes that work with gcc?
> 
>  Nothing really special, i.e. here is what I have in Makefile.am:
> 
>       AM_CXXFLAGS = -DLMI_PCH_HEADER="<pchfile.hpp>"
> 
> and, for the GUI code:
> 
>       libskeleton_la_CXXFLAGS = ... -DLMI_PCH_HEADER="<pchfile_wx.hpp>"

I'll change the '.cpp' files, but leave 'Makefile.am' to you.

> GC> (2) #include "non-wx-pch-file.hpp" XOR #include "wx-pch-file.hpp"
> 
>  This does seem simpler to me too, I admit that I'm not sure why had we
> decided to go with LMI_PCH_HEADER. The trouble is that I have a nagging
> feeling there was a good reason for this, but I can't remember (nor find in
> the archives) what it was.

Big changes are much easier with git, because 'git log' is actually usable
and therefore no 'ChangeLog' file needs to be maintained; so, if we need
to change this later, it's no big deal.

> GC> I'll plan to make this change globally, if it meets your needs:

Oh--BTW, some files don't have this stuff:

$grep --files-without-match hdrstop *.cpp
bcc_ar.cpp
bcc_cc.cpp
bcc_ld.cpp
bcc_rc.cpp
ce_product_name.cpp
ce_skin_name.cpp
database_document.cpp
database_view_editor.cpp
elapsed_time.cpp
ihs_crc_comp.cpp
ledger_xml_io.cpp
md5.cpp
multidimgrid_tools.cpp
product_editor.cpp
rounding_document.cpp
rounding_view_editor.cpp
tier_view_editor.cpp

I think standalone utilities:
  bcc_ar.cpp bcc_cc.cpp bcc_ld.cpp bcc_rc.cpp
  elapsed_time.cpp ihs_crc_comp.cpp
probably shouldn't have it, but I'll add it to the others above.