[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Removing comment induces compiler error

From: Vadim Zeitlin
Subject: Re: [lmi] Removing comment induces compiler error
Date: Thu, 9 Mar 2017 03:24:10 +0100

On Wed, 8 Mar 2017 01:18:29 +0000 Greg Chicares <address@hidden> wrote:

GC> And it would be nice to reap an unanticipated dividend from all that
GC> PCH work.

 Yes, indeed.

GC> Thus:
GC> On 2017-03-06 00:45, Vadim Zeitlin wrote:
GC> |  There are several possible solutions, but I think the most robust one
GC> | could be to disable this warning with a compiler pragma in pchfile_wx.hpp
GC> | and get rid of wx_dependent_objects in the makefiles entirely. This would
GC> | keep things at the code, rather than the makefile, level which is IMO
GC> | preferable and would rely on a convention we already use ("all files using
GC> | wx must include pchfile_wx.hpp") instead of using heuristics.
GC> | 
GC> |  If you agree with this solution, please let me know if you'd like me to
GC> | make (and test) the simple implementing it.
GC> Great idea--yes please!

 I think it's as simple as this (tested using the official build system):


 Please let me know if I'm missing anything, thanks,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]