[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] [lmi-commits] master e653dbd 03/10: Refactor: transplant two r
|
From: |
Greg Chicares |
|
Subject: |
Re: [lmi] [lmi-commits] master e653dbd 03/10: Refactor: transplant two recipe lines |
|
Date: |
Thu, 2 May 2019 01:34:35 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 2019-05-01 23:05, Vadim Zeitlin wrote:
> On Tue, 30 Apr 2019 22:17:55 -0400 (EDT) Greg Chicares <address@hidden> wrote:
>
> GC> branch: master
> GC> commit e653dbd9d57f5d490864b7efb67c90657e9aae18
>
> Sorry, but this doesn't look right:
[...]
> But second, and worse, removing it from the "initial_setup" target is
> actively harmful because this means that extracting the archive with bsdtar
> using --directory=$(ad_hoc_dir) will fail: while bsdtar(1) is not totally
> clear about whether the directory specified by this option must exist, a
> simple test shows that it really must and that bsdtar exits with "could not
> chdir to $directory" error if it doesn't.
Oh.
Thanks for catching that.
> So I'm afraid we really need to move at least the second mkdir command
> back. AFAICS creating $(prefix) just before copying into it should be fine,
> however.
Reverted.