Re: [lmi] PATCH: C++20 and clang

[Vadim Zeitlin]

On Mon, 19 Apr 2021 16:28:31 +0200 I wrote:

>  Hello,
> 
>  First of all, the TL;DR summary: I've created
> 
>       https://github.com/let-me-illustrate/lmi/pull/179

 Sorry, I've had to update this PR as I had sent the original post too
quickly, after checking that clang build succeeded -- but the GUI test in
the MSW build has failed later because I've made a stupid mistake. I've
corrected it now, but this resulted in a change to most of the commits
mentioned in the original message.

 It's probably simpler to just visit, and follow the links on, the URL
above now, but here are the updated SHA-1s if you prefer to follow the
links from the email:

>  I think at least some of these warnings should be fixed, e.g. the first
> one is fixed by
> 
> https://github.com/let-me-illustrate/lmi/commit/9a4888100bbf4029c72fc9c598122079674dcb9f
> 
> which is clearly a good idea anyhow, as using enum for defining constants
> is a C-ism not useful with contemporary C++ any more.

 This one is still the same.

>  Similarly, the ones in about_dialog.cpp are fixed by
> 
> https://github.com/let-me-illustrate/lmi/commit/48ef5370a50e6e0d656916506c09ee3eb890d2c2

 This one is now

https://github.com/let-me-illustrate/lmi/commit/ae672dce6506bb5ffe6817967dc87fe8bd0cda13

>  Additionally, the PR also includes the changes needed to make the code
> compile with __cplusplus value corresponding to C++20 by avoiding the
> #errors in the existing code, please see
> 
> https://github.com/let-me-illustrate/lmi/commit/f2023190695640d4ef0e887fab46852f0338680b

 This one is

https://github.com/let-me-illustrate/lmi/commit/1a86b8f35a1a9b3fd019d232fdf11dc01cd2194e

>  And, finally, I've also disabled a couple of other warnings for clang. In
> 
> https://github.com/let-me-illustrate/lmi/pull/179/commits/d703b4b42f826507e0b3651a55615d25357af1b9

https://github.com/let-me-illustrate/lmi/commit/9ce718859691a8636395d584b626ed01a86959a6

>  Disabling the warning about volatile in
> 
> https://github.com/let-me-illustrate/lmi/pull/179/commits/104ef04feb7e037769ec22905ca39b7ddbc9c83a

 And this, and final, commit is

https://github.com/let-me-illustrate/lmi/commit/e1ffd97febe8b220d585176805bb4182ee3ad754

 Sorry again for the inconvenience,
VZ

pgpPPncJrwAN0.pgp
Description: PGP signature