Re: [lmi] PATCH: C++20 and clang

[Vadim Zeitlin]

On Mon, 19 Apr 2021 21:19:26 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:

GC> On 4/19/21 4:29 PM, Vadim Zeitlin wrote:
GC> > On Mon, 19 Apr 2021 16:28:31 +0200 I wrote:
GC> > 
GC> >>  Hello,
GC> >> 
GC> >>  First of all, the TL;DR summary: I've created
GC> >> 
GC> >>  https://github.com/let-me-illustrate/lmi/pull/179
GC> 
GC> If I just do this:
GC> 
GC> $ git fetch --all
GC> From https://github.com/vadz/lmi
GC>  * [new branch]          clang-cxx20 -> xanadu/clang-cxx20
GC>    40c119dea..9414edf44  master      -> xanadu/master
GC> 
GC> then is that what you want me to pull? It has these nine new
GC> commits (the tenth was my own):
GC> 
GC> $git log -10 --oneline xanadu/clang-cxx20
GC> e1ffd97fe (xanadu/clang-cxx20) Disable clang warnings about using volatile 
in C++20 mode
GC> 9ce718859 Disable -Wunused-parameter warning in Boost.Numeric header
GC> 1a86b8f35 Use std::endian when using C++20
GC> e4cb44b01 Disable clang enum-related warnings in C++20 mode
GC> ae672dce6 Use wxSizerFlags for creating the "About" dialog
GC> 9a4888100 Use constexpr instead of enum for defining constants
GC> 709aa9fa0 Enable verbose build in CI autotools jobs
GC> 54cd54b6f Don't show test-suite.log in CI script if it doesn't exist
GC> e54575c99 Use C++20 when building lmi with autotools
GC> 8be683cc1 Record speed measurements

 This is surprising, the commits up to and including 709aa9fa0 are already
part of the main repository at Savannah because I had pushed them there
(they only affect "my" files). In fact, there is another commit that I
pushed since then (9414edf44ff43ee28a28d2b1efe2abd5d8dfa1fa) and I don't
understand why didn't your "git-fetch --all" fetch it from there. Surely
you have a configured remove (probably called "origin"?) for the Savannah
repository?

 In any case, the commits that are part of this PR are the first 6 commits
in the list above (they're also those that appear on the web page if you
open the URL above in the browser). You should be able to apply them by
using

        $ git cherry-pick ..xanadu/clang-cxx20

on master.

 Please let me know if you find out why you don't see the latest commits
from Savannah locally, I don't see any explanation for this right now.

 Thanks,
VZ

pgpZ5DuQglCYN.pgp
Description: PGP signature