lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] PATCH: Switch to using std::filesystem


From: Greg Chicares
Subject: Re: [lmi] PATCH: Switch to using std::filesystem
Date: Thu, 29 Apr 2021 14:13:33 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0

On 4/29/21 10:51 AM, Vadim Zeitlin wrote:
> On Thu, 29 Apr 2021 02:33:07 +0000 Greg Chicares <gchicares@sbcglobal.net> 
> wrote:
[...]
> GC> Do you have a strong
> GC> preference for me to squash this into a single commit?
> GC> Would you object if it enters origin/master as thirty-four
> GC> distinct commits?

I thought it would be a shame to discard history, even if you don't
think that history would be valuable...provided that retaining the
distinct commits breaks no natural invariant such as...

>  Not "strong" and not really an objection, but this would create a problem
> if anyone wants to run "git bisect" in the future, as ~30 commits among
> those 34 wouldn't build, so would have to be skipped when bisecting.

Oh. I hadn't realized. That's a fatal objection. I'll squash it. Thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]