Re: [lwip-devel] netconn/socket: converting len argument to size_t

[Jakob Stoklund Olesen]

Simon Goldschmidt wrote:
>> You have my vote.
>> 
>> One of my first mistakes in working with lwIP was calling
>> tcp_write() with a size_t length. This meant that objects over 64K
>> would get silently truncated. I would have preferred ERR_MEM.
> 
> That is a different issue: you should have turned on the correct
> warnings when compiling and the compiler would have warned you there.

True.

> I'm not planning to convert the raw API right now: neither the send
> window nor the pbuf length can hold more than 64K, so it is not
> strictly necessary to convert the raw API functions. However, if you
> have a sndbuf > 64K, it might be desirable to do so...

Yeah, not much need right now. tcp_pcb.snd_buf is also u16_t...

> Anyway, that's a different issue from sockets/netconn, so I'm not
> doing this now.

No problem. I'll probably look into it once the tcp_enqueue stuff goes in.

/stoklund