Re: [Mingw-cross-env-list] MemoryBarrier needed for dbus

[Mark Brand]

On 09/24/2011 02:44 AM, Volker Grabsch wrote:
> Mark Brand schrieb:
> > Just updated dbus [1].
> >
> > Dbus now uses MemoryBarrier which is in the Windows API but not in
> > MinGW, so I patched it [2] into the relevant dbus source file. This
> > is not a particularly elegant solution, but I'm not sure we want to
> > patch our windows.h just for this one case.
> [...]
> > [1] http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/8bfc6d601bb1
> > [2] 
> > http://lists-archives.org/mingw-users/15935-missing-definition-of-memorybarrier.html
> Thanks for you work! I agree that this is better than
> touching windows.h.

Notice also that that dbus source file already has a bunch of missing 
winapi definitions. If Tony's suggestion that mingw-w64's version of 
windows.h might supply MemoryBarrier, then that might explain why the 
dbus project didn't add MemoryBarrier.

> However, could you mention the URL [2] in the patch, please?
> Or is there a good reason not to mention it?

It *is* mentioned in the patch's git-style commit message. Or do you 
mean that the URL should be added by the patch to the dbus source file 
as a C comment?

Mark