Re: [Monotone-devel] nvm.source-tree-cleanup

[Richard Levitte]

In message <address@hidden> on Fri, 04 Feb 2011 01:06:28 +0100, Thomas Keller 
<address@hidden> said:

me> Am 03.02.11 10:09, schrieb Thomas Keller:
me> > I'll review the latest changes later on, I was a bit
me> > busy over the last couple of days...
me> 
me> Here we go:
me> 
me> * A make clean in the source directory now purges the original files as
me>   it makes no difference if these reside in the source or build
me>   directory. We might need some extra logic there and loop over
me>   CLEANFILES and only remove those that are not in $srcdir. Or is there
me>   a better way?

I fixed by removing all the $(*_copied) from $(CLEANFILES) and having
them handled in a clean-local target instead.

me> * I removed the removal of doc/*-specific resources in the main
me>   Makefile.am's mostlyclean-local - I think this is probably done more
me>   cleanly in doc/Makefile.am now.

doc/html isn't automatically removed...  I've added that to
clean-local as well.

me> * make distcheck prints out a spurious warning at the beginning:
me>     make[1]: Circular htmldir <- html dependency dropped.
me>   Can this be safely ignored or is this something we should look after?
me>   (Its issued right after makeinfo --html)

Hmm, I don't get that.  Does that happen when you build in the source
directory?

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish