[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous worki
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected |
Date: |
Sat, 23 Jul 2016 13:10:51 +0200 |
On Sat, Jul 23, 2016, at 08:39, Rishabh Dave wrote:
> Patch is attached. Checking answer is much, much better! :)
First, you have trailing whitespace again.
Second, why use free_and_assign()? present_name should be null;
there is no need to free anything.
Third, try this: ^R ^T M-G / <Enter> M-G .. <Enter>; the behavior
is absurd: it selects the last item in the directory.
And fourth: I'm still not sure whether I like M-G to highlight
the originating dir when it happens to jump to the parent dir.
Other jumps highlight the first item; it would be nicer if all
jumps do that. (Pressing <Enter> on the first item is not
jumping; it is selecting.)
Benno
--
http://www.fastmail.com - mmm... Fastmail...
- [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Rishabh Dave, 2016/07/18
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Benno Schulenberg, 2016/07/20
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Rishabh Dave, 2016/07/20
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Benno Schulenberg, 2016/07/21
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Rishabh Dave, 2016/07/22
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Benno Schulenberg, 2016/07/22
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Rishabh Dave, 2016/07/23
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected,
Benno Schulenberg <=
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Rishabh Dave, 2016/07/24
- Re: [Nano-devel] [PATCH] browser: when using goto prompt, previous working directory remains unselected, Benno Schulenberg, 2016/07/24