Re: [Nano-devel] warning the user that some keys cannot be rebound

[Benno Schulenberg]

On Mon, Sep 12, 2016, at 18:56, Rishabh Dave wrote:
> On Sun, Sep 11, 2016 at 8:46 PM, Benno Schulenberg wrote:
> > No, it doesn't.  If I put "bind Mxa help all" in my .nanorc,
> > it gets accepted -- but it shouldn't.  Please add a condition
> > for that, as the first condition in the series.
> 
> Okay, I was only considering cases like MSpaces (missing hyphen).
> Cases like Mxa are also covered this time.

-    } else if (keycopy[0] == '^' && (keycopy[1] < 64 || keycopy[1] > 127)) {
+    } else if ((keycopy[1] != '-' && keycopy[0] == '^' &&
+               ((keycopy[1] < 64 || keycopy[1] > 127) || [...]

O, come on, you can't be serious.  You didn't even test this!
"bind Mxa help all" still gets accepted.

Benno

-- 
http://www.fastmail.com - The way an email service should be