nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] several ASCII characters from 64 to 127 cannot


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] several ASCII characters from 64 to 127 cannot be rebound but are accepted without protest
Date: Tue, 20 Sep 2016 11:25:46 +0200

On Sun, Sep 18, 2016, at 14:45, Rishabh Dave wrote:
> Attached patch disallows rebinding of ^@, ^[, ^{, ^|, ^}, ^~, ^`

-               (keycopy[0] == '^' && ((keycopy[1] < 64 || keycopy[1] > 127) ||
+               (keycopy[0] == '^' &&
+               ((keycopy[1] <= 64 || keycopy[1] >= 123) ||
+               keycopy[1] == 91 ||  keycopy[1] == 96 ||

Why change the operator (from < to <=)?  Changing just the numbers
would be clearer.  And don't change the wrapping on that line --
there is no need.

Benno

-- 
http://www.fastmail.com - IMAP accessible web-mail




reply via email to

[Prev in Thread] Current Thread [Next in Thread]