[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] File insertion revamp
From: |
David Ramsey |
Subject: |
Re: [Nano-devel] File insertion revamp |
Date: |
Wed, 15 Feb 2017 11:04:56 -0600 |
> On Wed, Feb 15, 2017 at 5:05 AM, Benno Schulenberg
> <address@hidden> wrote: That is a clear description.
Good to know.
> It took three readings, but now I get it. It is the "move from" that
> doesn't convey that it in fact it means "insert a buffer into
> another". So I would propose to call that function "ingraft_buffer()",
> to avoid the word "insert" which we already use for insert_file().
>
> And move_to_buffer() I would then call extract_buffer().
Done.
> Yes, renaming copy_from_filestruct() everywhere would be better as a
> separate commit. But the new function gets the better name right
> away.
Done.
> Yes, but don't change the uncut one now -- not related.
Okay.
> Meld it. I didn't really write anything -- I just deleted superfluous
> lines. :) Plus the change is so small... just absorb it.
Done.
> Right.
Done.
> Yes, that would be good.
Reported.
Version 2 of the revamp is attached.
insertfile-revamp-2.zip
Description: Zip archive
- [Nano-devel] File insertion revamp, David Ramsey, 2017/02/13
- Re: [Nano-devel] File insertion revamp, Benno Schulenberg, 2017/02/14
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/14
- Re: [Nano-devel] File insertion revamp, Benno Schulenberg, 2017/02/15
- Re: [Nano-devel] File insertion revamp,
David Ramsey <=
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/15
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/15
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/15
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/16
- Re: [Nano-devel] File insertion revamp, Benno Schulenberg, 2017/02/19
- Re: [Nano-devel] File insertion revamp, Benno Schulenberg, 2017/02/19
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/19
- Re: [Nano-devel] File insertion revamp, Benno Schulenberg, 2017/02/21
- Re: [Nano-devel] File insertion revamp, David Ramsey, 2017/02/21
- Re: [Nano-devel] File insertion revamp, Benno Schulenberg, 2017/02/22