Re: [Nano-devel] File insertion revamp

[Benno Schulenberg]

On Mon, Feb 20, 2017, at 01:15, David Ramsey wrote:
> On Sun, Feb 19, 2017 at 5:29 AM, Benno Schulenberg
> <address@hidden> wrote:
> > +    else {
> > +       bool force_another_line = FALSE;
> >
> > Don't declare a variable in the middle of a function.
> 
> Not done yet (although I've locally renamed force_another_line to
> mac_line_needs_newline, which should make what it's used for clearer),
> because I don't understand what you mean here.
> 
> Are you objecting to declaring a variable at the beginning of an else
> block instead of globally?

Sorry, my mistake.  Somehow I overlooked the opening brace.

> (As an aside, it's not always obvious what your preferred coding style
> is.  Do you have any plans to add a coding style document or something
> similar?

No.

>  No offense, but... I'd prefer to spend more time working on
> code and less time working on style nits,

Okay.  Then I'll fix the style things when I apply your patches.

> > The topline of the buffer to be discarded could then simply be called
> > 'trash'.
> 
> Considering that extract_buffer() is also used to cut text, [...]

No, I just meant inside replace_marked_buffer().

Benno

-- 
http://www.fastmail.com - A no graphics, no pop-ups email service