[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #48807] gsvd function needs BIST tests updated

From: Carnë Draug
Subject: [Octave-bug-tracker] [bug #48807] gsvd function needs BIST tests updated
Date: Sat, 1 Oct 2016 22:59:17 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Follow-up Comment #16, bug #48807 (project octave):

Yes, it is usable but this is not the right fix. I think that if we didn't had
the incomplete gsvd already in the repository and someone submitted as it is,
we wouldn't accept it and would ask the submitter to do it correctly without
those issues. But we still don't have to accept it. gsvd has not been released
in any Octave version yet so we can just revert the changes and do it properly

This was my mistake, I should have tested gsvd better and check Matlab
compatibility before merging. If it was not in the repo, and I were to add it
now to core in this state, would it really be accepted?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]