[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #48807] gsvd function needs matlab compatible

From: Rik
Subject: [Octave-bug-tracker] [bug #48807] gsvd function needs matlab compatible interface
Date: Sun, 2 Oct 2016 15:40:23 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

Follow-up Comment #19, bug #48807 (project octave):

I pushed a cset on the dev branch that prepares the gsvd function for
implementation.  It updates the docstring to refer to the API that will be
implemented, not the existing one.  I added input validation for a third
input, for when "economy-sized" decompositions are implemented.  The code was
very old in using the deprecated error_state variable so I got rid of that in
favor of the new xmatrix_value call.  I added FIXME notes where more work has
to be done.  For example, I added a warning if the user has inputs of type
single.  Eventually that part of the code can be deleted when the connection
to the single gsvd class is made.  I added a simple BIST test taken from the
examples in the Matlab documentation.  All of the BIST tests are now tagged
with the 48807 bug number so they won't cause failures to show up in 'make
check'.  See http://hg.savannah.gnu.org/hgweb/octave/rev/98eeed41f372.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]