[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55736] Segfault when copying source file text

From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #55736] Segfault when copying source file text to clipboard in octave-gui
Date: Wed, 20 Feb 2019 09:09:25 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Follow-up Comment #11, bug #55736 (project octave):

Torsten:  If you make this change, then you should see the crash when
constructing the documentation object:

diff --git a/libgui/src/documentation.cc b/libgui/src/documentation.cc
--- a/libgui/src/documentation.cc
+++ b/libgui/src/documentation.cc
@@ -104,7 +104,7 @@ namespace octave
     connect(m_help_engine, SIGNAL(setupFinished()),
             m_help_engine->searchEngine(), SLOT(indexDocumentation()));
-    if (! m_help_engine->setupData())
+    //    if (! m_help_engine->setupData())
         QMessageBox::warning (this, tr ("Octave Documentation"),

I've attached an additional patch that I think protects all uses of
m_help_engine.  There is probably a better way to do this job, but for now it
would be great if we could just avoid the crash.

It would probably be good to insert a message in the documentation pane itself
that explains possible reasons that the re is no text, but that could wait
until later.

(file #46314)

Additional Item Attachment:

File name: doc-diffs.txt                  Size:8 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]