octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57171] typos in configure.ac comments


From: Rik
Subject: [Octave-bug-tracker] [bug #57171] typos in configure.ac comments
Date: Tue, 5 Nov 2019 10:36:00 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko

Update of bug #57171 (project octave):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

I checked in the changes in here
https://hg.savannah.gnu.org/hgweb/octave/rev/ab13485346c2.

I reverted the change to the enable documentation comment so that it continues
ot read as


### Determine if documentation should and can be built.


This is not the idiomatic phrase "can and should", but actually the order of
operations.  The first thing configure checks is whether it should build the
documentation by looking for the --disable-docs option.  Once it determines it
should build the docs then it checks whether it can build the documentation.

I also added the bug number to the commit message.  Again, this is convention,
but it allows later developers to quickly tie a changeset to the reason for
the changeset.

Marking as fixed and closing report.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57171>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]