[Octave-bug-tracker] [bug #57044] Use gnulib without hg subrepo and `bootstrap` with proper revision control

[Kai Torben Ohlhus]

Update of bug #57044 (project octave):

                  Status:         Patch Submitted => Patch Reviewed         

    _______________________________________________________

Follow-up Comment #34:

Regarding comment #32 (jwe): No objections, please apply =)

Regarding comment #33 (Mike), comment #27 (Mike):

I tried to reproduce your example 


bootstrap.conf
: ${GNULIB_REVISION=a8e125d24942bc581fda1628a61a60b979ab7087}


https://git.savannah.gnu.org/cgit/gnulib.git (orign/master)
24d438e5e579478a4c4d4fece2f10a68a1836268 (01/21/2020 05:59:10 PM -0800)

LOCAL (orign/master)
020f5190955808cafb670d2be6afb7d5faf69621 (01/16/2020 09:41:34 PM +0530)

LOCAL (master)
1fabf601fa87579a9eaed42c92c6bb9a97922c1d (12/13/2019 12:19:56 AM +0100)


DISABLE INTERNET

./bootstrap

./bootstrap: Bootstrapping from checked-out octave sources...
Note: checking out 'a8e125d24942bc581fda1628a61a60b979ab7087'.

... successful



GNULIB_REVISION=020f5190955808cafb670d2be6afb7d5faf69621 ./bootstrap

./bootstrap: Bootstrapping from checked-out octave sources...
Previous HEAD position was a8e125d24 * lib/mknodat.c: Remove incorrect
comments.
HEAD is now at 020f51909 vcs-to-changelog: Fix parsing of fndecl without
args.

... successful



GNULIB_REVISION=24d438e5e579478a4c4d4fece2f10a68a1836268 ./bootstrap

./bootstrap: Bootstrapping from checked-out octave sources...
fatal: reference is not a tree: 24d438e5e579478a4c4d4fece2f10a68a1836268
<dead>


GNULIB_REVISION= ./bootstrap

./bootstrap: Bootstrapping from checked-out octave sources...
./bootstrap: getting gnulib files...
Cloning into 'gnulib'...
fatal: Unable to look up git.sv.gnu.org (port 9418) (Name or service not
known)
<dead>


ENABLE INTERNET

GNULIB_REVISION=24d438e5e579478a4c4d4fece2f10a68a1836268 ./bootstrap

./bootstrap: Bootstrapping from checked-out octave sources...
./bootstrap: getting gnulib files...
Cloning into 'gnulib'...

<old "gnulib" folder removed, startover with a fresh clone>


GNULIB_REVISION= ./bootstrap

<just take what is there>


You are right.  It is maybe 99% of what we want.  But most important, we can
easily control via one hash inside bootstrap.conf for a plain standard Octave
developer a very easy to maintain and understand way to get the gnulib right.

I things go wrong, bootstrap is smart enough to issue an "tree"-error about
git id mismatches.  Thus lets do the change now than later and gain new
experience with these border cases.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57044>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/