[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.
From: |
John W. Eaton |
Subject: |
[Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1 |
Date: |
Thu, 8 Apr 2021 13:50:57 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #60357 (project octave):
Operating System: Any => Microsoft Windows
_______________________________________________________
Follow-up Comment #6:
Markus: I started making the same change as you did:
diff --git a/libinterp/corefcn/mappers.cc b/libinterp/corefcn/mappers.cc
--- a/libinterp/corefcn/mappers.cc
+++ b/libinterp/corefcn/mappers.cc
@@ -133,10 +133,9 @@ Compute the inverse cosine in radians fo
%! v = [0, pi, pi/2, pi/2];
%! assert (real (acos (x)), v);
-%!test <52627>
-%! ## Same test code as above, but intended only for test statistics on Mac
and
-%! ## Windows. Their trig/hyperbolic functions have huge tolerances.
-%! if (! ismac () && ! ispc ()), return; endif
+## Same test code as above, but intended only for test statistics on Mac and
+## Windows. Their trig/hyperbolic functions have huge tolerances.
+%!testif ; ismac () || ispc () <*52627>
%! x = [1, -1, i, -i] .* 1e150;
%! v = [0, pi, pi/2, pi/2];
%! assert (real (acos (x)), v);
and then noticed that for each of these cases, the code in the two sets of
tests are now identical. That may not have always been true? But unless I'm
missing something, it suggests we should merge them.
I also noticed that the two sets of tests use different bug numbers. We don't
currently have a way to specify more than one bug number for a test
(build-aux/update-bug-script.sh and test.m would need to be modified to handle
that). I suppose we could just add additional bug numbers in a comment. For
bugs that have been fixed, the real point is to be able to say that any
failure is a regression, so the particular bug number is less important than
the "*".
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?60357>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #60357] Failing tests on Windows, Markus Mützel, 2021/04/07
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` on Windows with LAPACK 3.9.1, Markus Mützel, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` on Windows with LAPACK 3.9.1, Rik, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` on Windows with LAPACK 3.9.1, John W. Eaton, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1,
John W. Eaton <=
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Rik, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Rik, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Rik, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, John W. Eaton, 2021/04/08
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/09
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Markus Mützel, 2021/04/09
- [Octave-bug-tracker] [bug #60357] Failing test for `qz` with LAPACK 3.9.1, Rik, 2021/04/18