[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: input validation in C++ internal functions
From: |
Andreas Weber |
Subject: |
Re: input validation in C++ internal functions |
Date: |
Thu, 22 May 2014 10:10:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
Am 05.05.2014 19:24, schrieb Jordi GutiƩrrez Hermoso:
> On Mon, 2014-05-05 at 16:39 +0100, Michael D. Godfrey wrote:
>> On 05/05/2014 07:47 AM, Andreas Weber wrote:
>>> In my humble optinion no function should segfault when accessible from
>>> the octave interpreter.
>> I am pretty sure that Jordi agrees with this, and it s a long-standing
>> principle that Octave should never seg fault.
>
> Yeah, it's a bug, although I consider it a minor one, since it's in
> internal functions.
>
> My complaint at the time was that almost none of the internal C++
> functions do any argument-checking. I'm not against this sort of
> patch, but I am against cluttering every internal C++ function with
> argument-checking boilerplate code. Andy's patch in question at the
> moment looks reasonable to me, but it's a stopgap around a larger
> problem.
Pushed to stable
http://hg.savannah.gnu.org/hgweb/octave/rev/5e99fd6ea758 after
discussion in IRC. -- Andy
- input validation in C++ internal functions, Andreas Weber, 2014/05/05
- Re: input validation in C++ internal functions, Michael D. Godfrey, 2014/05/05
- Re: input validation in C++ internal functions, Jordi GutiƩrrez Hermoso, 2014/05/05
- Re: input validation in C++ internal functions,
Andreas Weber <=
- Re: input validation in C++ internal functions, Juan Pablo Carbajal, 2014/05/22
- Re: input validation in C++ internal functions, Andreas Weber, 2014/05/23
- Re: input validation in C++ internal functions, Juan Pablo Carbajal, 2014/05/23
- Re: input validation in C++ internal functions, John W. Eaton, 2014/05/23
- Re: input validation in C++ internal functions, Juan Pablo Carbajal, 2014/05/23