[Octave-patch-tracker] [patch #8837] normest1

[Carnë Draug]

Follow-up Comment #9, patch #8837 (project octave):

Copied from IRC:

* instead of "if ((nargin <= 1) || isempty (t)), t = 2" you can just do
"function [est, v, w, k] = normest1(A, t = 2, X, varargin)"
* when you do "[est, idx] = max (sum (abs (A)))" but then don't use est, use
'[~, idx] = ...'. Also, it's a good idea to specify the dimension on sum() and
max()
* instead of 'X = X / n', use 'X /= n' which is reduces memory usage
* use ! instead of ~
* estold should probably be est_old since that's two words, same with
possiblebreak
* do not use hard tabs. Use spaces only. The code looks wrong on my system
because hard tabs are 2 spaces and other people will also have different setup
than yours
* what's the purpose of this code? It does nothing
https://bpaste.net/show/d6fb97659aa5
* this loop could be easily vectorized https://bpaste.net/show/5475ca4e2c04
* you should remove trailing whitespace. There's a lot of it
* when it comes to texinfo, you should use @dots instead ...
* also, don't use empty lines yourself, you can write lists on texinfo too
* instead of making the uppercase yourself on '@code{AFUN (FLAG, X)}', use
@var. Note that the purpose of @var is not to uppercase text. That effect is
only for terminal output.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8837>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/