[Octave-patch-tracker] [patch #9985] [octave forge] (statistics) Add function confusionchart

[Philip Nienhuis]

Follow-up Comment #4, patch #9985 (project octave):

Thanks.

I tried 'demo confusionchart' but got this error:

>> demo confusionchart
confusionchart example 1: 1
 Yt = [8 5 6 8 5 3 1 6 4 2 5 3 1 4]';
 Yp = [8 5 6 8 5 2 3 4 4 5 5 7 2 6]';
 confusionchart (Yt, Yp, "Title", ...
   "Demonstration with summaries","Normalization",...
   "absolute","ColumnSummary", "column-normalized","RowSummary",...
   "row-normalized")

ans = 1
confusionchart example 1: failed
set.FontName: function called with too many outputs


This is a new error check introduced in (dev) Octave-7.0.0 (also for inputs).
Although 7+ is not yet current I think it's better to fix it already now so we
don't have to do that when Octave-7.1.0 is released.
Could you please have a look at this? I tried myself, I do know classdef but
I'm not very proficient in the classdef nitty-gritty when fixing bugs.
If you're on Windows and need Octave-7.0.0 I can upload a dev version for you.
On Linux you'd need to build Octave-7.0.0 yourself I'm afraid.

Style issues:
- put all if clauses between parentheses (e.g., L.296 in
ConfusionMatricxChart.m and L.55 in confusionchart)
- make sure all strings are enclosed in double not single quotes (e.g., L.60
in confusionchart.m)

I've fixed these style things in optimalleaforder.m / patch #10034 (to be
pushed soon), but for these 2 funcs I'll leave it up to you.

IMO also the texinfo help texts should be just a little more elaborate, that
is, a structured listing of all inputs and outputs, what they are, esp. what
they should look like (e.g., along the lines of "Nx4 matrix of doubles", which
column or row contains what data, required orientation/dimension of vectors,
allowed variations), can they be empty, can they be omitted, what are default
values, maybe which function(s) can produce them; "array of labels" =>
"cellstr array of labels" (Nx1 or 1xN, or doesn't that matter?). That sort of
detail. All meant to aid users when things don't go as they hoped for.
As the texinfo currently stands it implicitly assumes quite a bit of knowledge
that you and I as experienced Octave users take for granted but less
experienced users simply don't have.

Hint: use @itemize / @item / @end itemize macros to enumerate multiple inputs
in the order that the function expects them. In some Octave functions @table
@asis / @end table is used for this. Similar for outputs. I think I've given a
Texinfo style URL in an earlier patch report.

BTW I saw Matlab has confusionchart both in the Statistics and machine
learning toolbox (that I have access to) but also in the Deep learning toolbox
- never heard of that until today :-)


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9985>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/