Re: [Pan-users] Decoding incomplete parts (Was: ANN: Pan 0.94 "Ready! Fire! Aim!")

[Kevin Brammer]

I get

patch: **** malformed patch at line 9: != Article::COMPLETE), NULL);

guessing because of new lines or something.  Anyone else?



On 4/23/06, Charles Kerr <address@hidden> wrote:
> > On 4/23/06, Charles Kerr <address@hidden> wrote:
> >> It's time for your weekly Pan release.  You know the drill -- lots of
> >> bug fixes, a few tweaks, and a few new features.  Most everything this
> >> week came directly from suggestions here on pan-users, so keep up the
> >> good work! :)
> >>
> >> Details and tarballs are at http://pan.rebelbase.com/ .
> >
> > hi,
> > i just compiled it and downloaded something. there's two things i noticed:
> > when you now download files, at the end of a file pan takes up 100%cpu
> > and freezes for a few seconds, data transfer from the newsserver stops
> > also. after 5-10 seconds it's responsible again and continues with the
> > next file. seems like now it decodes the whole file when it gets
> > finished instead of decoding each part as it gets downloaded. is this
> > a bug/feature or just me?
>
> This is probably because 0.93 and 0.94 use uudeview to decode multiparts,
> just to see how it goes.  So far IMO it's slower but more reliable.
> If you want to profile some decoding sessions with sysprof and mail
> me the results I'll take a look at them -- we may be able to speed it
> up somewhat.
>
> > The other thing i noticed is that i cant download incomplete files
> > anymore (those marked with the red binary-icon). they get downloaded
> > and seem to get decoded (including the short gui-freeze) but they
> > never appear in the destination dir.
>
> Here's a patch for that.
>
> --- task-article.cc.bak 2006-04-23 13:40:48.000000000 -0500
> +++ task-article.cc     2006-04-23 13:40:52.000000000 -0500
> @@ -277,6 +277,8 @@
>        Log::add_err (_("Error initializing uulib"));
>      else
>      {
> +      // if it's not complete, take whatever parts we can get
> +      UUSetOption (UUOPT_DESPERATE, (_article.get_part_state() !=
> Article::COMPLETE), NULL);
> +
>        foreach_const (ArticleCache::strings_t, filenames, it)
>          if ((res = UULoadFile (const_cast<char*>(it->c_str()), 0, 0)) !=
> UURET_OK)
>            Log::add_err_va (_("Couldn't load \"%s\": %s"), it->c_str(),
>
>
>
>
> _______________________________________________
> Pan-users mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/pan-users
>