[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Re: PDF_EINVAL in the text module
From: |
gerel |
Subject: |
Re: [pdf-devel] Re: PDF_EINVAL in the text module |
Date: |
Fri, 06 Jun 2008 13:48:45 -0300 |
> Date: Fri, 6 Jun 2008 09:17:54 +0200 (CEST)
> From: "Aleksander Morgado" <address@hidden>
>
> > The code in the text module is using PDF_EINVAL as the used error code
> > in the case of invalid parameters. All other modules are using
> > PDF_EBADDATA for the same purpose.
>
> Yes, I added it to have a difference between
> a)Invalid input parameter (ex. NULL pointer) --> PDF_EINVAL
> b)Invalid data contained in the input parameter (ex. Invalid UTF-8 encoded
> string) --> PDF_EBADDATA
Hey aleks, that's a good idea but the meaning of PDF_EBADDATA is the one of
PDF_EINVAL too in other modules :-/, so you could add a new type like
PDF_EBADTEXT
instead. That means, replace PDF_EINVAL with PDF_EBADDATA and PDF_EBADDATA with
PDF_EBADTEXT. What do you think ?
cheers
-gerel