poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Code simplification in pk_hserver_make_hyperlink


From: Jose E. Marchesi
Subject: Re: [PATCH] Code simplification in pk_hserver_make_hyperlink
Date: Thu, 02 Apr 2020 18:58:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

    >> -  if (gethostname (hostname, 128) != 0)
    >> +  if (asprintf(&str, "app://%s:%d/%d/%c/%s",
    >> +               hostname,
    >> +               hserver_port,
    >> +               token,
    >> +               type,
    >> +               cmd
    >> +               ) == -1)
    >
    > Isn't asprintf a GNU extension that will make poke no longer portable to
    > other libc implementations beside glibc?
    
    You already use is elsewhere. It's part of gnulib in case the libc
    doesn't provide it.
    
Actually, the implementation that is in gnulib comes from glibc.  I
think it is Paul who updates these glibc bits from time to time... :)

If there are no more objections, this patch is OK for master.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]