[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Code simplification in pk_hserver_make_hyperlink
From: |
Dan Čermák |
Subject: |
Re: [PATCH] Code simplification in pk_hserver_make_hyperlink |
Date: |
Fri, 03 Apr 2020 00:24:52 +0200 |
address@hidden (Jose E. Marchesi) writes:
> >> - if (gethostname (hostname, 128) != 0)
> >> + if (asprintf(&str, "app://%s:%d/%d/%c/%s",
> >> + hostname,
> >> + hserver_port,
> >> + token,
> >> + type,
> >> + cmd
> >> + ) == -1)
> >
> > Isn't asprintf a GNU extension that will make poke no longer portable to
> > other libc implementations beside glibc?
>
> You already use is elsewhere. It's part of gnulib in case the libc
> doesn't provide it.
>
> Actually, the implementation that is in gnulib comes from glibc. I
> think it is Paul who updates these glibc bits from time to time... :)
So does that mean that glibc is required or that the code between gnulib
and glibc is shared?
>
> If there are no more objections, this patch is OK for master.
> Thanks!
signature.asc
Description: PGP signature