poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make 'git status' more useful


From: Jose E. Marchesi
Subject: Re: make 'git status' more useful
Date: Sat, 11 Apr 2020 17:12:20 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Bruno.
    
    After doing "git pull" and rebuilding, I had compilation errors:
    
    ../lib/.libs/libpoke.a(libpoke_la-pkl.o): In function `pkl_compile_buffer':
    /media/develdata/devel/POKE/poke/lib/pkl.c:251: undefined reference to 
`rpl_printf'
    
    These were caused by a stale left-over lib/stdio.h file that cause trouble 
when
    gl/stdio.h was meant to be included.
    
    Usually, 'git status' should show me such left-over files. But currently,
    'git status' is not very useful before it reports a number of files after
    'make distclean':
    
            doc/poke.info-1
            doc/poke.info-2
            lib/pkl-asm.pkc
            lib/pkl-gen.pkc
            lib/pkl-lex.c
            lib/pkl-lex.h
            lib/pkl-tab.c
            lib/pkl-tab.h
            lib/pkl-tab.output
            lib/pvm-vm.h
            lib/pvm-vm1.c
            lib/pvm-vm2.c
            po/poke.pot
            src/nodelist
    
    Generated files that are not in the distribution tarball ought to be removed
    by "make clean" (or "make distclean" or "make maintainer-clean") [1].
    
    Generated files that are in the distribution tarball ought to listed in
    .gitignore.
    
    [1] https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
    
    I proposed the two attached patches to implement this.

    
    2020-04-11  Bruno Haible  <address@hidden>
    
        Clean some generated files.
        * lib/Makefile.am: Delete pkl-tab.output during 'make mostlyclean'.
        * src/Makefile.am: Delete nodelist during 'make mostlyclean'.
        * .gitignore: Update accordingly.
    
    2020-04-11  Bruno Haible  <address@hidden>
    
        Make 'git status' empty after "make distclean".
        * .gitignore: Ignore generated files that are distributed in the
        tarball.

This is OK for master.
Thanks!
    
    >From a78d1843ee891aab7b9219eceae4ae22cda27551 Mon Sep 17 00:00:00 2001
    From: Bruno Haible <address@hidden>
    Date: Sat, 11 Apr 2020 16:11:09 +0200
    Subject: [PATCH 1/2] Clean some generated files.
    
    * lib/Makefile.am: Delete pkl-tab.output during 'make mostlyclean'.
    * src/Makefile.am: Delete nodelist during 'make mostlyclean'.
    * .gitignore: Update accordingly.
    ---
     .gitignore      | 2 --
     ChangeLog       | 7 +++++++
     lib/Makefile.am | 7 +++++++
     src/Makefile.am | 7 +++++++
     4 files changed, 21 insertions(+), 2 deletions(-)
    
    diff --git a/.gitignore b/.gitignore
    index 84551f7..4ffb615 100644
    --- a/.gitignore
    +++ b/.gitignore
    @@ -38,7 +38,6 @@ config.h.in
     /build-aux/install-sh
     /build-aux/missing
     /autom4te.cache/
    -/doc/nodelist
     /doc/poke.info
     /doc/pokeint.info
     /doc/pkl.info
    @@ -64,7 +63,6 @@ config.h.in
     /src/pkl-lex.h
     /src/pkl-tab.c
     /src/pkl-tab.h
    -/src/pkl-tab.output
     /src/pvm-vm.h
     /src/pvm-vm1.c
     /src/pvm-vm2.c
    diff --git a/ChangeLog b/ChangeLog
    index fe318f6..441d679 100644
    --- a/ChangeLog
    +++ b/ChangeLog
    @@ -1,3 +1,10 @@
    +2020-04-11  Bruno Haible  <address@hidden>
    +
    +   Clean some generated files.
    +   * lib/Makefile.am: Delete pkl-tab.output during 'make mostlyclean'.
    +   * src/Makefile.am: Delete nodelist during 'make mostlyclean'.
    +   * .gitignore: Update accordingly.
    +
     2020-04-11  Jose E. Marchesi  <address@hidden>
     
        * lib/pk-utils.c: Include stdlib.h.
    diff --git a/lib/Makefile.am b/lib/Makefile.am
    index d1a8d36..8c13271 100644
    --- a/lib/Makefile.am
    +++ b/lib/Makefile.am
    @@ -15,6 +15,11 @@
     # You should have received a copy of the GNU General Public License
     # along with this program.  If not, see <http://www.gnu.org/licenses/>.
     
    +MOSTLYCLEANFILES =
    +CLEANFILES =
    +DISTCLEANFILES =
    +MAINTAINERCLEANFILES =
    +
     dist_pkgdata_DATA = pkl-rt.pk std.pk
     
     lib_LTLIBRARIES = libpoke.la
    @@ -68,6 +73,8 @@ BUILT_SOURCES = pkl-tab.h pkl-lex.c \
                     pvm-vm.h pvm-vm1.c pvm-vm2.c
     
     AM_YFLAGS = -d -t --report=state
    +MOSTLYCLEANFILES += pkl-tab.output
    +
     AM_LFLAGS = -d
     
     libpoke_la_CPPFLAGS = -I$(top_builddir)/gl -I$(top_srcdir)/gl \
    diff --git a/src/Makefile.am b/src/Makefile.am
    index 1ea217a..d6c78a4 100644
    --- a/src/Makefile.am
    +++ b/src/Makefile.am
    @@ -15,6 +15,10 @@
     # You should have received a copy of the GNU General Public License
     # along with this program.  If not, see <http://www.gnu.org/licenses/>.
     
    +MOSTLYCLEANFILES =
    +CLEANFILES =
    +DISTCLEANFILES =
    +MAINTAINERCLEANFILES =
     
     dist_pkgdata_DATA = pk-cmd.pk pk-dump.pk pk-save.pk pk-copy.pk
     
    @@ -48,4 +52,7 @@ if HSERVER
       poke_LDADD += -lpthread
     endif
     
    +# Created by doc/Makefile.am.
    +MOSTLYCLEANFILES += nodelist
    +
     # End of Makefile.am



reply via email to

[Prev in Thread] Current Thread [Next in Thread]