[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Setter methods for names/types of a struct type
From: |
Konstantinos Chasialis |
Subject: |
Re: [PATCH] Setter methods for names/types of a struct type |
Date: |
Sun, 28 Jun 2020 22:59:45 +0300 |
User-agent: |
SquirrelMail/1.4.23 [email.uoa.gr] |
I won't forget to CC the list again I promise :D.
> I was referring to pk_alloc and pk_assert, not to the type builders. I
> don't think we want to expose these two calls to the callers of libpoke.
>
Ok, I will remove them.
>This is a matter of personal preference, but `type' is perfectly ok for
>the main type being referred in the call. In this case, the struc type.
>When two types are passed as arguments, like in
>pk_struct_type_set_ftype, the main subject type can still be `type' and
>the other `field_type' or something like that.
Noted, I will change them.
Do you want me to send a reply to this thread with the above changes?