[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

fix build failure during "make check"

From: Bruno Haible
Subject: fix build failure during "make check"
Date: Mon, 13 Jul 2020 11:31:56 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-179-generic; KDE/5.18.0; x86_64; ; )


The daily continuous integration build found an issue:

make[2]: Entering directory 
make  values
make[3]: Entering directory 
gcc -DHAVE_CONFIG_H -I. -I../../poke  -I../../gl -I../../gl -I../../common 
-I../../libpoke -I../../libpoke -Wall  -g -O2 -MT values-values.o -MD -MP -MF 
.deps/values-values.Tpo -c -o values-values.o `test -f 'values.c' || echo 
In file included from values.c:24:0:
term-if.h: In function 'pk_printf':
term-if.h:38:7: warning: unused variable 'r' [-Wunused-variable]
   int r;
mv -f .deps/values-values.Tpo .deps/values-values.Po
/bin/bash ../../libtool  --tag=CC   --mode=link gcc  -g -O2   -o values  
values-values.o ../../gl/libgnu.la ../../libpoke/libpoke.la 
libtool: link: gcc -g -O2 -o .libs/values values-values.o  
../../gl/.libs/libgnu.a -lreadline ../../libpoke/.libs/libpoke.so -pthread
../../libpoke/.libs/libpoke.so: undefined reference to `rpl_vasprintf'
../../libpoke/.libs/libpoke.so: undefined reference to `rpl_asprintf'
collect2: error: ld returned 1 exit status
Makefile:1748: recipe for target 'values' failed
make[3]: *** [values] Error 1

The reason is that libpoke.so has undefined symbols rpl_vasprintf, rpl_asprintf.
A library shouldn't have undefined symbols. gl/libpoke/libgnu.la is supposed to
define these symbols. This patch fixes it (and another patch the warning above).
OK to push?

Attachment: 0001-Fix-build-failure-during-make-check.patch
Description: Text Data

Attachment: 0002-Fix-build-warning-during-make-check.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]