[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] poke.libpoke tests bugfix.

From: Jose E. Marchesi
Subject: Re: [PATCH] poke.libpoke tests bugfix.
Date: Sun, 06 Sep 2020 17:10:58 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>>> Hello, it seems to work with $(abs_srcdir).
>>> Please confirm :)
>> After make check RUNTESTFLAGS=libpoke.exp:
>> /home/jemarch/gnu/hacks/poke/build/testsuite/poke.libpoke/.libs/values:
>> symbol lookup error:
>> /home/jemarch/gnu/hacks/poke/build/testsuite/poke.libpoke/.libs/values:
>> undefined symbol: pk_val_equal_p
> Ok, this is due to this being present in the
> testsuite/poke.libpoke/values libtool wrapper script:
>     # Add our own library path to LD_LIBRARY_PATH
> LD_LIBRARY_PATH="/usr/local/lib:/home/jemarch/gnu/hacks/poke/build/libpoke/.libs:$LD_LIBRARY_PATH"
> Last time this happened to us was due to poke/Makefile.am using the
> wrong variable in poke_LDADD, and fixed by Bruno in commit
> e29c0f69646ae3ade502b85edd2ce87a1fea3c4d.
> However, now the only dependencies in testsuite/poke.libpoke/Makefile.am
> are a couple of libtool libraries:
> values_LDADD = $(top_builddir)/gl/libgnu.la \
>                $(top_builddir)/libpoke/libpoke.la
> And these should be doing the right thing...
> Ideas?

Some findings...

A dependency on libtextstyle is being dragged in by

# Libraries that this one depends upon.
dependency_libs=' -R/usr/local/lib  -lreadline -L/usr/local/lib 
/usr/local/lib/libtextstyle.la -lm -lncurses'

Eventually that leads to libtool to prepend the installed ladir of
libtextstyle (/usr/local/lib) to LD_LIBRARY_PATH.  Adding LTLIBTEXTSTYLE
to values_LDADD fixes this:

values_LDADD = $(top_builddir)/gl/libgnu.la \
               $(top_builddir)/libpoke/libpoke.la \

This works, but I don't fully understand why.

For the time being, Kostas, please use this workaround in your patch,
which is then OK for master.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]