[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: compilation error in VPATH build
From: |
Jose E. Marchesi |
Subject: |
Re: compilation error in VPATH build |
Date: |
Sat, 20 Feb 2021 12:06:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Bruno.
>> On the other hand, files that ARE packed into a tarball should not be erased
>> by "make distclean" (only by "make maintainer-clean"), and should reside in
>> srcdir, per the GNU Coding Standards
>> <https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html>.
>
> Other violations of this rule also exist for
>
> man/poke.1
> libpoke/pkl-lex.h
> libpoke/pkl-lex.c
> poke/pk-map-lex.c
> poke/pk-map-lex.h
>
> All these files are packaged in the tarball (which is good, because it
> means that the builder does not need to have 'help2man' and 'flex' installed).
> But they are currently stored in the builddir:
>
> $ ll man/poke.1 build-64/man/poke.1
> -rw-rw-r-- 1 bruno bruno 2128 Feb 20 00:37 build-64/man/poke.1
> -rw-rw-r-- 1 bruno bruno 2073 Nov 21 20:39 man/poke.1
>
> $ ll libpoke/pkl-lex.? build-64/libpoke/pkl-lex.?
> -rw-rw-r-- 1 bruno bruno 112175 Feb 20 00:34 build-64/libpoke/pkl-lex.c
> -rw-rw-r-- 1 bruno bruno 18610 Feb 20 00:34 build-64/libpoke/pkl-lex.h
> -rw-rw-r-- 1 bruno bruno 104521 Nov 21 20:39 libpoke/pkl-lex.c
> -rw-rw-r-- 1 bruno bruno 18596 Nov 21 20:39 libpoke/pkl-lex.h
> -rw-rw-r-- 1 bruno bruno 16235 Jan 25 08:57 libpoke/pkl-lex.l
>
> $ ll poke/pk-map-lex.? build-64/poke/pk-map-lex.?
> -rw-rw-r-- 1 bruno bruno 69762 Feb 20 00:37 build-64/poke/pk-map-lex.c
> -rw-rw-r-- 1 bruno bruno 18969 Feb 20 00:37 build-64/poke/pk-map-lex.h
> -rw-rw-r-- 1 bruno bruno 69602 Nov 21 20:39 poke/pk-map-lex.c
> -rw-rw-r-- 1 bruno bruno 18958 Nov 21 20:39 poke/pk-map-lex.h
> -rw-rw-r-- 1 bruno bruno 4207 Jan 25 08:57 poke/pk-map-lex.l
>
> Fixed through the two attached patches.
OK for master.
Thanks!