|
From: | Indu Bhagat |
Subject: | Re: [PATCH 1/2] pickles: ctf: minor enhancements and add CTF_Dictionary type |
Date: | Thu, 25 Feb 2021 14:15:56 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 |
On 2/25/21 12:37 AM, Jose E. Marchesi wrote:
+ CTF_Type[type_size] types @type_off; + string[header.cth_strlen] strings @str_off;We usually write labels leving a space between the @ and the offset expression. Other than that, this is OK for master. Thanks!
Thanks for the review. Pushed Part 1/2 of the patch series with that change included. Will update the patch 2/2 and send V2 of the same, Indu
[Prev in Thread] | Current Thread | [Next in Thread] |