[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] pickles: ctf: minor enhancements and add CTF_Dictionary
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH 1/2] pickles: ctf: minor enhancements and add CTF_Dictionary type |
|
Date: |
Fri, 26 Feb 2021 00:12:13 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> On 2/25/21 12:37 AM, Jose E. Marchesi wrote:
>>> + CTF_Type[type_size] types @type_off;
>>> + string[header.cth_strlen] strings @str_off;
>> We usually write labels leving a space between the @ and the offset
>> expression.
>> Other than that, this is OK for master.
>> Thanks!
>>
>
> Thanks for the review.
> Pushed Part 1/2 of the patch series with that change included.
Thanks!
> Will update the patch 2/2 and send V2 of the same,
> Indu