[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "make check" still succeeds when there are test failures

From: Jose E. Marchesi
Subject: Re: "make check" still succeeds when there are test failures
Date: Sat, 06 Mar 2021 17:38:12 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Bruno.

> Currently, when DejaGnu is installed, "make check" reports the
> number of unexpected failures in its summary, but the exit code
> of "make check" is still 0.
> It would be more useful if the exit code was set to 1 if there
> are unexpected failures, because
>   - This is the traditional way a test suite is meant to behave.
>   - Then the CI runs would send a failure email, and I could notify you.
> I can also make the CI send a failure email without the change,
> by grepping the log for the string "unexpected failures". But that
> feels like a half-baken approach.

This is now fixed in both master and maint/poke-1.
I was waiting for having all the tests passing in 32-bit hosts ;)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]