[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6426] Patches needed for text import

From: Ben Pfaff
Subject: [patch #6426] Patches needed for text import
Date: Mon, 18 Feb 2008 21:08:00 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20071128 Iceweasel/ (Debian-

Follow-up Comment #2, patch #6426 (project pspp):

Thank you for your comments.

>The var-sheet-add-features.patch is going to conflict badly with 
>some edits I'm working on. Can you hold off on this one for a day 
>or two.

No problem.  It's a conceptually simple change.  If I have to reimplement it,
it's not a big deal for me.

>In var-store-add-features, I suggest that instead of a "for-input"
>property of boolean type, you use g_param_spec_enum to create a 
>enumerated type property called "format-type" or something 

Will do.

>Instead of the declarations :
>int trailing_rows;
>bool for_input;
>can you write:
>gint trailing_rows;
>gboolean for_input;

I think that the glib typedefs for int and other standard types from C89 are
a stupid idea that should never have seen the light of day.  There is some
sense in gboolean, since C89 didn't have a boolean type.  But for consistency
I'll change both of these.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]