[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spreadsheet Import Dialog

From: John Darrington
Subject: Re: Spreadsheet Import Dialog
Date: Sun, 10 Mar 2013 20:30:51 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Sun, Mar 10, 2013 at 09:12:59AM -0700, Ben Pfaff wrote:
     On Sun, Mar 10, 2013 at 09:03:09AM -0700, Ben Pfaff wrote:
     > On Sat, Mar 09, 2013 at 07:44:10PM +0100, John Darrington wrote:
     > > I'm posting this proposed change for review purposes.  It enables 
import of 
     > > spreadsheet files using the gui.
     > This sounds like a useful feature.  I'm going to look over the changes
     > today.
     I see some "printf"s sprinkled into the code.  I guess these are stray
     debugging code that has not yet been removed.
     It looks like most of the patch is moving code around.  I see a some new
     code, but it is hard to spot in the motion.  Is there any particular
     code that you'd like to draw my attention to?  If not, then this seems
     like a reasonable set of changes to me.
Yes.  Like you say it is work in progress, but I thought it was stable enough
for a first review.  The idea is, that the "Text Import Dialog" would be 
into an "Import Dialog" so that it could import any kind of foreign format.

Hence, most of the changes, as you say, has been separating existing code into 
different files.   The new work I have done is in page-sheet-spec.c


PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]