[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spreadsheet Import Dialog

From: Ben Pfaff
Subject: Re: Spreadsheet Import Dialog
Date: Mon, 11 Mar 2013 21:46:41 -0700
User-agent: Mutt/1.5.21 (2010-09-15)

On Sun, Mar 10, 2013 at 08:30:51PM +0100, John Darrington wrote:
> On Sun, Mar 10, 2013 at 09:12:59AM -0700, Ben Pfaff wrote:
>      On Sun, Mar 10, 2013 at 09:03:09AM -0700, Ben Pfaff wrote:
>      > On Sat, Mar 09, 2013 at 07:44:10PM +0100, John Darrington wrote:
>      > > I'm posting this proposed change for review purposes.  It enables 
> import of 
>      > > spreadsheet files using the gui.
>      > 
>      > This sounds like a useful feature.  I'm going to look over the changes
>      > today.
>      I see some "printf"s sprinkled into the code.  I guess these are stray
>      debugging code that has not yet been removed.
>      It looks like most of the patch is moving code around.  I see a some new
>      code, but it is hard to spot in the motion.  Is there any particular
>      code that you'd like to draw my attention to?  If not, then this seems
>      like a reasonable set of changes to me.
> Yes.  Like you say it is work in progress, but I thought it was stable enough
> for a first review.  The idea is, that the "Text Import Dialog" would be 
> generalised
> into an "Import Dialog" so that it could import any kind of foreign format.
> Hence, most of the changes, as you say, has been separating existing code 
> into 
> different files.   The new work I have done is in page-sheet-spec.c

Yes, I did see that there was some new work.

As long as you feel comfortable that this change does not introduce
regressions, then I'm happy to see it checked in.  It will probably be
easier to read later patches that add features if they do not include
all the code movement.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]