[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 3/4] target-arm: Combine user-only and softmmu get
Re: [Qemu-arm] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()
Fri, 12 Feb 2016 15:15:22 +0000
On 12 February 2016 at 15:12, Edgar E. Iglesias
> On Thu, Feb 11, 2016 at 07:11:48PM +0000, Peter Maydell wrote:
>> The user-mode versions of get/set_r13_banked() exist just to assert
>> if they're ever called -- the translate time code should never
>> emit calls to them because SRS from user mode always UNDEF.
>> There's no code in the softmmu versions that can't compile in
>> CONFIG_USER_ONLY, so combine the two functions rather than
>> having completely split versions under ifdefs.
>> Signed-off-by: Peter Maydell <address@hidden>
> Hi Peter,
> Do we really need the assert?
> If we keep it, can't we have it for both -user and -softmmu (avoiding the
I would be happy to entirely drop the assert, yes.
[Qemu-arm] [PATCH 1/4] target-arm: Clean up trap/undef handling of SRS, Peter Maydell, 2016/02/11