[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 1/2] Fix confusing argument names of do_unaligned_

From: Sergey Sorokin
Subject: Re: [Qemu-arm] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions
Date: Tue, 14 Jun 2016 15:01:39 +0300

Seems arm_cpu_do_unaligned_access() function could use it. It uses 
cpu_mmu_index() for now but I think use of mmu_idx is preferred. Anyway it's 
the subject for another patch.

13.06.2016, 10:47, "Aurelien Jarno" <address@hidden>:
> On 2016-06-10 19:26, Sergey Sorokin wrote:
>>  There are functions cpu_unaligned_access() and do_unaligned_access() that
>>  are called with access type and mmu index arguments. But these arguments
>>  are named 'is_write' and 'is_user' in their declarations.
>>  The patch fixes the names to avoid a confusion.
> Unless I missed something, it seems that the is_user/mmu_idx argument is
> never used. Should we maybe just drop it?
> Otherwise it looks fine.
> --
> Aurelien Jarno GPG: 4096R/1DDD8C9B
> address@hidden http://www.aurel32.net

reply via email to

[Prev in Thread] Current Thread [Next in Thread]