[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 05/20] target/arm: Add MMU indexes for secure v8M
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH 05/20] target/arm: Add MMU indexes for secure v8M |
Date: |
Fri, 25 Aug 2017 10:34:00 +0100 |
On 22 August 2017 at 16:08, Peter Maydell <address@hidden> wrote:
> Now that MPU lookups can return different results for v8M
> when the CPU is in secure vs non-secure state, we need to
> have separate MMU indexes; add the secure counterparts
> to the existing three M profile MMU indexes.
> @@ -2206,7 +2217,11 @@ static inline int cpu_mmu_index(CPUARMState *env, bool
> ifetch)
> */
> if ((env->v7m.exception > 0 && env->v7m.exception <= 3)
> || env->v7m.faultmask) {
> - return arm_to_core_mmu_idx(ARMMMUIdx_MNegPri);
> + mmu_idx = ARMMMUIdx_MNegPri;
> + }
Incidentally this is not exactly the right check to make when
the security extension is present, but at this point in the
series it's the best we can do (the right check requires us
to have exception banking support in the NVIC so we can
check secure HF and nonsecure HF separately); the patch to
do it right will come after the NVIC patches.
thanks
-- PMM
- Re: [Qemu-arm] [Qemu-devel] [PATCH 11/20] target/arm: Make VTOR register banked for v8M, (continued)
- [Qemu-arm] [PATCH 19/20] target/arm: Move regime_is_secure() to target/arm/internals.h, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 09/20] target/arm: Make CONTROL register banked for v8M, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 16/20] target/arm: Make CCR register banked for v8M, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 01/20] target/arm: Implement ARMv8M's PMSAv8 registers, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 05/20] target/arm: Add MMU indexes for secure v8M, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 20/20] target/arm: Implement BXNS, and banked stack pointers, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 18/20] target/arm: Make CFSR register banked for v8M, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 03/20] target/arm: Add state field, feature bit and migration for v8M secure state, Peter Maydell, 2017/08/22
- [Qemu-arm] [PATCH 14/20] target/arm: Make MPU_RNR register banked for v8M, Peter Maydell, 2017/08/22