[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4 |
Date: |
Thu, 18 Oct 2018 11:20:27 +0100 |
On 17 October 2018 at 22:14, Richard Henderson
<address@hidden> wrote:
> On 10/17/18 1:25 PM, Aaron Lindsay wrote:
>> I suppose pmcrn (the local variable) should've been set to 0 before this
>> patch and updated here to be 4.
>
> That's plausible.
>
>> Anyway, by splitting these patches apart, my intention was to separate
>> the plumbing work from turning on the water. If you believe it is better
>> to do both in the same patch, I'll make that change for v7.
>
> Fair. I'll let Peter weigh in for final decision.
No strong opinion -- rth has reviewed this set, not me.
thanks
-- PMM
- [Qemu-arm] [PATCH v6 13/14] target/arm: Implement PMSWINC, (continued)
- [Qemu-arm] [PATCH v6 13/14] target/arm: Implement PMSWINC, Aaron Lindsay, 2018/10/10
- [Qemu-arm] [PATCH v6 10/14] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER, Aaron Lindsay, 2018/10/10
- [Qemu-arm] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Aaron Lindsay, 2018/10/10
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Richard Henderson, 2018/10/16
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Aaron Lindsay, 2018/10/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Richard Henderson, 2018/10/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Aaron Lindsay, 2018/10/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Richard Henderson, 2018/10/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4,
Peter Maydell <=
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4, Aaron Lindsay, 2018/10/18
[Qemu-arm] [PATCH v6 14/14] target/arm: Send interrupts on PMU counter overflow, Aaron Lindsay, 2018/10/10
Re: [Qemu-arm] [PATCH v6 00/14] More fully implement ARM PMUv3, Peter Maydell, 2018/10/16