[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v6 12/16] gdbstub: add support for vAttach packets
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH v6 12/16] gdbstub: add support for vAttach packets |
Date: |
Fri, 16 Nov 2018 11:11:26 +0100 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Nov 15, 2018 at 10:42:03AM +0100, Luc Michel wrote:
> Add support for the vAttach packets. In multiprocess mode, GDB sends
> them to attach to additional processes.
>
> Signed-off-by: Luc Michel <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> gdbstub.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index ada53ac559..0427d1c4f0 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1340,10 +1340,45 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> break;
> }
> goto unknown_command;
> }
> break;
> + } else if (strncmp(p, "Attach;", 7) == 0) {
> + unsigned long pid;
> +
> + p += 7;
> +
> + if (qemu_strtoul(p, &p, 16, &pid)) {
> + put_packet(s, "E22");
> + break;
> + }
> +
> + process = gdb_get_process(s, pid);
> +
> + if (process == NULL) {
> + put_packet(s, "E22");
> + break;
> + }
> +
> + cpu = get_first_cpu_in_process(s, process);
> +
> + if (cpu == NULL) {
> + /* Refuse to attach an empty process */
> + put_packet(s, "E22");
> + break;
> + }
> +
> + process->attached = true;
> +
> + s->g_cpu = cpu;
> + s->c_cpu = cpu;
> +
> + snprintf(buf, sizeof(buf), "T%02xthread:%s;", GDB_SIGNAL_TRAP,
> + gdb_fmt_thread_id(s, cpu, thread_id,
> sizeof(thread_id)));
> +
> + put_packet(s, buf);
> + break;
> } else {
> goto unknown_command;
> }
> case 'k':
> /* Kill the target */
> --
> 2.19.1
>
- [Qemu-arm] [PATCH v6 00/16] gdbstub: support for the multiprocess extension, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 02/16] gdbstub: introduce GDB processes, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 03/16] gdbstub: add multiprocess support to '?' packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 01/16] hw/cpu: introduce CPU clusters, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 12/16] gdbstub: add support for vAttach packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 08/16] gdbstub: add multiprocess support to Xfer:features:read:, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 05/16] gdbstub: add multiprocess support to vCont packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets, Luc Michel, 2018/11/15