[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions |
Date: |
Mon, 20 May 2019 09:47:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hello,
On 5/6/19 4:20 PM, Cédric Le Goater wrote:
> Hello,
>
> Here is a series adding a couple of cleanups to the Aspeed SoCs to
> prepare ground for extensions and new SoCs.
>
> Thanks,
>
> C.
>
> Changes since v1:
>
> - moved enum defining the Aspeed controller names under aspeed_soc.h
> - removed AspeedSoCInfo 'sdram_base' field
> - fixed clang compilation
>
> Cédric Le Goater (3):
> aspeed: add a per SoC mapping for the interrupt space
> aspeed: add a per SoC mapping for the memory space
I think these two patches are fine to go even if Philippe's comments
are not addressed. There are valid but not a blocker to me.
> aspeed: use sysbus_init_child_obj() to initialize children
Philippe has taken over this patch in a larger series which will go
through Eduardo's tree, if I understood well the emails. When merged,
we can try to re-merge the RTC patchset from Joel. I think we made
things a little more complex than they should have been.
Thanks,
C.
> include/hw/arm/aspeed_soc.h | 40 ++++++-
> hw/arm/aspeed.c | 8 +-
> hw/arm/aspeed_soc.c | 226 ++++++++++++++++++++++--------------
> 3 files changed, 184 insertions(+), 90 deletions(-)
>
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/3] aspeed: add a per SoC mapping for the interrupt space, (continued)
- [Qemu-arm] [PATCH v2 2/3] aspeed: add a per SoC mapping for the memory space, Cédric Le Goater, 2019/05/06
- [Qemu-arm] [PATCH v2 3/3] aspeed: use sysbus_init_child_obj() to initialize children, Cédric Le Goater, 2019/05/06
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions,
Cédric Le Goater <=
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Philippe Mathieu-Daudé, 2019/05/20
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Cédric Le Goater, 2019/05/20
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Cédric Le Goater, 2019/05/20
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Philippe Mathieu-Daudé, 2019/05/20
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Peter Maydell, 2019/05/23
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Cédric Le Goater, 2019/05/23
- Re: [Qemu-arm] [PATCH v2 0/3] aspeed: cleanups and extensions, Eduardo Habkost, 2019/05/24