[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/12] npcm7xx: Add config symbol
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 01/12] npcm7xx: Add config symbol |
Date: |
Wed, 8 Jul 2020 19:04:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/8/20 6:58 PM, Havard Skinnemoen wrote:
> On Wed, Jul 8, 2020 at 9:56 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>> +config NPCM7XX
>>> + bool
>>> + select A9MPCORE
>>> + select ARM_GIC
>>> + select PL310 # cache controller
>>> + select SERIAL
>>> + select UNIMP
>>
>> And this in patch 5: "Add NPCM730 and NPCM750 SoC models"
>
> Is it still OK for earlier patches to use $(CONFIG_NPCM7XX) in Makefiles?
>
I haven't reviewed them yet, so no.
I'd do this way:
- Add to the first peripheral that requires $(CONFIG_NPCM7XX):
config NPCM7XX
bool
- Then when you add the SoC, complete with:
select A9MPCORE
select ARM_GIC
select PL310 # cache controller
select SERIAL
select UNIMP
- [PATCH v4 00/12] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines, Havard Skinnemoen, 2020/07/07
- [PATCH v4 02/12] hw/misc: Add NPCM7xx System Global Control Registers device model, Havard Skinnemoen, 2020/07/07
- [PATCH v4 03/12] hw/misc: Add NPCM7xx Clock Controller device model, Havard Skinnemoen, 2020/07/07
- [PATCH v4 04/12] hw/timer: Add NPCM7xx Timer device model, Havard Skinnemoen, 2020/07/07
- [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models, Havard Skinnemoen, 2020/07/07
- Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models, Havard Skinnemoen, 2020/07/08
- Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models, Havard Skinnemoen, 2020/07/08