Re: [PATCH v6 04/82] target/arm: Implement SVE2 integer unary operations (predicated)

[Peter Maydell]

On Fri, 30 Apr 2021 at 21:30, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v2: Fix sqabs, sqneg (laurent desnogues)
> ---
>  target/arm/helper-sve.h    | 13 +++++++++++
>  target/arm/sve.decode      |  7 ++++++
>  target/arm/sve_helper.c    | 29 +++++++++++++++++++----
>  target/arm/translate-sve.c | 47 ++++++++++++++++++++++++++++++++++++++
>  4 files changed, 92 insertions(+), 4 deletions(-)

> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index 42fe315485..bbab84e81d 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -535,8 +535,8 @@ static inline uint64_t do_sadalp_d(uint64_t n, uint64_t m)
>      return m + n1 + n2;
>  }
>
> -DO_ZPZZ(sve2_sadalp_zpzz_h, int16_t, H1_2, do_sadalp_h)
> -DO_ZPZZ(sve2_sadalp_zpzz_s, int32_t, H1_4, do_sadalp_s)
> +DO_ZPZZ(sve2_sadalp_zpzz_h, uint16_t, H1_2, do_sadalp_h)
> +DO_ZPZZ(sve2_sadalp_zpzz_s, uint32_t, H1_4, do_sadalp_s)
>  DO_ZPZZ_D(sve2_sadalp_zpzz_d, uint64_t, do_sadalp_d)
>
>  static inline uint16_t do_uadalp_h(uint16_t n, uint16_t m)
> @@ -557,8 +557,8 @@ static inline uint64_t do_uadalp_d(uint64_t n, uint64_t m)
>      return m + n1 + n2;
>  }
>
> -DO_ZPZZ(sve2_uadalp_zpzz_h, int16_t, H1_2, do_uadalp_h)
> -DO_ZPZZ(sve2_uadalp_zpzz_s, int32_t, H1_4, do_uadalp_s)
> +DO_ZPZZ(sve2_uadalp_zpzz_h, uint16_t, H1_2, do_uadalp_h)
> +DO_ZPZZ(sve2_uadalp_zpzz_s, uint32_t, H1_4, do_uadalp_s)
>  DO_ZPZZ_D(sve2_uadalp_zpzz_d, uint64_t, do_uadalp_d)
>
>  #undef DO_ZPZZ

These two hunks seem like they should have been in the previous patch.

(Why do we want to use uint* for the sadalp version?)

Other than that:

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM